Re: [libvirt] [PATCH] lxc: Do not try to reconnect inactive domain when do lxcStartup
On 05/03/2011 07:09 AM, Daniel P. Berrange wrote:
On Fri, Apr 29, 2011 at 03:21:03PM +0800, Osier Yang wrote:
> Otherwise if there are inactive lxc domains, lxcStartup will
> try to reconnect to sockets of these domains, which results in
> errors in libvirtd log.
> ---
> src/lxc/lxc_driver.c | 3 +++
> 1 files changed, 3 insertions(+), 0 deletions(-)
>
I don't see how this can be correct.
So, AFAICT, this patch means we will never reconnect to any LXC
VMs now.
The correct solution, is to refactor LXC driver startup to work
the same way as the QEMU driver startup.
- Load all the live state XML files (to pick up running VMs)
- Reconnect to all VMs
- Load all the persistent config XML files (to pick up any additional
inactive guets)
Osier, can you get this done before 0.9.1, or are we better off
reverting commit 0e7f7f85 for the release and resolving this post-release?
--
Eric Blake eblake(a)redhat.com +1-801-349-2682
Libvirt virtualization library http://libvirt.org
Attachments:
- signature.asc (application/pgp-signature — 619 bytes)