Re: [libvirt] [PATCH] virsh-domain: Add a missing check and fix leak in cmdScreenshot

25 Sep 2013


      On 09/25/2013 08:54 AM, Hongwei Bi wrote:
...
---
 tools/virsh-domain.c |    5 +++--
 1 files changed, 3 insertions(+), 2 deletions(-)

...
@@ -4620,7 +4621,7 @@ cmdScreenshot(vshControl *ctl, const vshCmd *cmd)
if (!file) {
         if (!(file=vshGenFileName(ctl, dom, mime)))
I fixed up the spacing of this = while at it.
...
-            return false;
+            goto cleanup;
ACK and pushed.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

    