Re: [libvirt] [PATCH v2 3/3] Use a hash table for storing MCS labels
On Fri, Jul 20, 2012 at 11:15:58AM -0600, Eric Blake wrote:
On 07/20/2012 10:59 AM, Daniel P. Berrange wrote:
> From: "Daniel P. Berrange" <berrange(a)redhat.com>
>
> Instead of using an O(n) efficiency linked list for storing
> MCS labels, use a hash table. Instead of having the list
> be global, put it in the SELinux driver private data struct
> to ensure uniqueness across different instances of the driver
Goodness on two fronts - improved efficiency and re-entrancy :)
I expanded the commit message to mention the thread safety aspect
of this.
Daniel
--
|: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org -o- http://virt-manager.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|