21 Mar
2019
21 Mar
'19
8:58 p.m.
On 3/19/19 8:46 AM, Daniel P. Berrangé wrote:
In the case of a network with forward=bridge, which has a bridge device listed, we are capable of setting bandwidth limits but fail to call the function to register them.
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com> --- src/network/bridge_driver.c | 39 ++++++++++++++++++++++++++----------- 1 file changed, 28 insertions(+), 11 deletions(-)
One thing missing is class_id XML reading in virDomainActualNetDefParseXML, that needs to be adjusted for TYPE_BRIDGE With that, code wise I'll give: Reviewed-by: Cole Robinson <crobinso@redhat.com> but I can't really comment on if there's any hidden pitfalls. But I'd say push it and we can figure it out in git master - Cole