On 06/02/2011 06:35 AM, Daniel P. Berrange wrote:
On Thu, Jun 02, 2011 at 05:48:39AM -0600, Eric Blake wrote:
> On 06/02/2011 05:26 AM, Daniel P. Berrange wrote:
>>
>> I've seen a strange build error from autobuild.sh which I'm thinking
>> may be related to this patch
>>
>> Generating drivers.html.tmp
>> Stubbing todo.html.in
>> Generating internals/locking.html.tmp
>> Generating internals/command.html.tmp
>
> There's no locking.html.in yet (except in your patch series), so this
> points to a bug in at least the VPATH rules for your conversion from
> locking.html.in to locking.html.
>
> You need to generate locking.html in $(srcdir), since it will be
> distributed pre-built as part of the tarball.
There's no special makefile rules for locking.html - all the
HTML stuff is wildcarded. The same error hits command.html
here too.
Ah, I see the problem now. locking.html is generated in $(srcdir), but
it goes via an intermediate locking.html.tmp, which is indeed generated
in $(builddir). I didn't catch it earlier, because I was testing an
in-tree build (where the builddir happens to already exist, since it is
also the srcdir).
I'll push the obvious fix (restoring the MKDIR_P, but without the
problematic $(builddir) that RHEL 5 didn't like).
--
Eric Blake eblake(a)redhat.com +1-801-349-2682
Libvirt virtualization library
http://libvirt.org