On 21/08/15 23:45, Martin Kletzander wrote:
On Fri, Aug 21, 2015 at 08:04:03PM +0200, Erik Skultety wrote:
> This minor cosmetical change allows us to later add new test case data
> including
> named servers.
> ---
> ...nput-data-admin-nomdns.json =>
> input-data-admin-nomdns-nonames.json} | 0
> ...put-data-admin-nomdns.json =>
> output-data-admin-nomdns-nonames.json} | 0
> tests/virnetdaemontest.c |
> 2 +-
> 3 files changed, 1 insertion(+), 1 deletion(-)
> rename tests/virnetdaemondata/{input-data-admin-nomdns.json =>
> input-data-admin-nomdns-nonames.json} (100%)
> rename tests/virnetdaemondata/{output-data-admin-nomdns.json =>
> output-data-admin-nomdns-nonames.json} (100%)
>
There is no need to rename this, all the subsequent (new) test files
can omit 'nomdns' from now on, for example 'admin-servers' if you add
saving of some server data. If you really want this to be named this
particular way, please use a normal name for the subject as this is
not very easy to find or understand from e.g. oneline log.
No, I agree with you,
it's unnecessary and I dropped the patch from my
branch.
Erik