Re: [libvirt] [PATCH 8/8] Revert "conf: Validate disk lun using correct types"
On Fri, May 06, 2016 at 11:19:05 -0400, John Ferlan wrote:
On 05/02/2016 10:32 AM, Peter Krempa wrote:
> This reverts commit c79ebf53b5fe0a33bf407b3bcb49e3a27ec97eb4.
>
> We can't just add checks to the XML parser once we've accepted such
> configuration in the past.
> ---
> src/conf/domain_conf.c | 22 ----------------------
> tests/qemuxml2argvtest.c | 3 +--
> 2 files changed, 1 insertion(+), 24 deletions(-)
>
There was a bz associated with that commit - that'll need to be
addressed in some manner...
I now have an even better justification for this that I didn't notice
earlier.
As of commits c820fbff9fbfe1f2549a5b60967496587f8d8bfc and
82ba41108acd0f3fc99f62effc7422a1e1e7c944 respectively we allow actually
to use the native iSCSI transport for disk type=lun so basically this
commit allows to actually use this with the volumes. I'll post it with
fixed commit message.
This basically should have been part of the latter commit.
Peter
Attachments:
- signature.asc (application/pgp-signature — 819 bytes)