Re: [libvirt] [PATCH] Remove isValidIfname.
On 05/20/2010 01:57 PM, Chris Lalancette wrote:
We shouldn't be checking validity in domain_conf, since
it can be used by multiple different hosts and hypervisors.
Remove the check completely.
-static bool
-isValidIfname(const char *ifname) {
- return ifname[strspn(ifname, VALID_IFNAME_CHARS)] == 0;
-}
Conditional ACK - you also need to nuke the (now unused) definition of
VALID_IFNAME_CHARS in domain_conf.h before pushing.
--
Eric Blake eblake(a)redhat.com +1-801-349-2682
Libvirt virtualization library http://libvirt.org
Attachments:
- signature.asc (application/pgp-signature — 619 bytes)