19 Jul
2010
19 Jul
'10
8:51 p.m.
On 07/17/10 - 06:08:03PM, Matthias Bolte wrote:
2010/7/8 Chris Lalancette <clalance@redhat.com>:
The virsh option error reporting was not being used consistently; some commands would spit out errors on missing required options while others would just silently fail. However, vshCommandOptString knows which ones are required and which ones aren't, so make it spit out an error where appropriate. The rest of the patch is just cleaning up the uses of vshCommandOptString to deal with the new error reporting.
Signed-off-by: Chris Lalancette <clalance@redhat.com> --- tools/virsh.c | 66 ++++++++++++++++++++------------------------------------ 1 files changed, 24 insertions(+), 42 deletions(-)
ACK.
Thanks, I pushed this one. -- Chris Lalancette