Re: [libvirt] [PATCH 1/5] lib: Add API for specific vCPU hot(un)plug
On Wed, Feb 22, 2017 at 12:55:21 +0000, Daniel Berrange wrote:
On Wed, Feb 22, 2017 at 01:34:54PM +0100, Peter Krempa wrote:
> On Wed, Feb 22, 2017 at 12:16:51 +0000, Daniel Berrange wrote:
> > On Fri, Feb 10, 2017 at 06:10:18PM +0100, Peter Krempa wrote:
> > > Similarly to domainSetGuestVcpus this commit adds API which allows to
> > > modify state of individual vcpus rather than just setting the count.
> > >
> > > This allows to enable CPUs in specific guest NUMA nodes to achieve any
> > > necessary configuration.
> > > ---
[...]
> I modelled this API after the qemuDomainSetGuestVcpus and
> qemuDomainGetGuestVcpusParams which already uses the string
> representation rather the harder-to-use bitmap one, since they are in
> for a while we can't change those.
Yep, we can't change those, but we can't avoid spreading the inconsistency
further, as all the other methods relating to CPUs aginst virDomain use
a bitmap
I obviously disagree with changing this (and don't expect me to change
the API) since I like the text representation in C way more than the
bitmaps.
The bindings still can use the natural bitmap representation by
converting the strings same way how we need to do it in virsh with the
binary bitmaps.
Attachments:
- signature.asc (application/pgp-signature — 833 bytes)