Re: [libvirt] [PATCH] leasetime support per <dhcp> and <host>

On 13.10.2016 00:03, Alberto Ruiz wrote: > Support for custom dhcp wide and per host leasetime. > > It is specified as a child tag for <dhcp>: > <dhcp> > <leasetime>24h</leasetime> > ... > </dhcp> > > And as an attribute for <host>: > <dhcp> > <host leasetime="7d" .../> > </dhcp> > > These are the different notations: > > -1 (infinite/unlimited lease) > 120 (seconds are the default unit, 120 seconds is the minimum, if less is > specified it will use 120) > 300s (seconds) > 5m (minutes) > 24h (hours) > 7d (days) > --- I know I'm stepping on a moving train (sorry for that), but I have two points to raise: 1) use git send-email, this patch is mangled by your MTA and does not apply. 2) 120 seconds is minimum because of dnsmasq? If so, I think we should error out instead of silently changing this to a different value behind user's back. Michal