On Mon, Mar 01, 2010 at 02:45:41PM +0100, Daniel Veillard wrote:
On Tue, Feb 23, 2010 at 03:35:04PM -0700, Jim Fehlig wrote:
Daniel P. Berrange wrote:
On Mon, Feb 22, 2010 at 02:50:07PM -0700, Jim Fehlig wrote:
Disk devices can be referenced by name in Xen, e.g. when modifying their configuration or remvoving them. As such, don't search xenstore for a device ID corresponding to the disk device. Instead, search the disks contained in the domain definition and use the disk's target name if found.
This approach allows removing a disk when domain is inactive. We obviously can't search xenstore when the domain is inactive.
This sounds reasonable, but I'm wondering if old XenD support the lookup-based on name ?
Yes, I had thought about this as well. Guess it depends on how old we are talking about. It exists in Xen 3.1.x and newer. I wonder if we should even care about Xen 3.0.x. The upstream tree hasn't been touched in 3 years.
Well we still ship this, so it would be appreciated if it didn't broke if libvirt got updated for some reasons ;-)
Yep, RHEL-5 still ships with Xen 3.0.x series & we aim to support that in libvirt. I think we can probably just make your new approach be conditional on the xendConfigVersion variable we already have. Daniel -- |: Red Hat, Engineering, London -o- http://people.redhat.com/berrange/ :| |: http://libvirt.org -o- http://virt-manager.org -o- http://deltacloud.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|