On Tue, Jul 29, 2025 at 10:42:09 +0200, Michal Prívozník via Devel wrote:
On 7/24/25 15:49, James Le Cuirot wrote:
From: James Le Cuirot <jlecuirot@microsoft.com>
Distros may provide compatibility symlinks after moving firmware files around, but they won't work for existing VMs when doing a straight string comparison.
virFileComparePaths has been used to do this, but it was previously only resolving the last path component, despite what the description says.
James Le Cuirot (2): util: Fully resolve paths with virFileComparePaths qemu: Match firmware with fully resolved and canonicalized paths
src/qemu/qemu_firmware.c | 11 ++++++----- src/util/virfile.c | 4 ++-- 2 files changed, 8 insertions(+), 7 deletions(-)
-- 2.49.0
Reviewed-by: Michal Privoznik <mprivozn@redhat.com>
and merged. Congratulations on your first libvirt contribution!
Note that this patch made the tests depend on host. While the pipelines did pass the local build on Fedora caused differences in test output which I attempted to fix, but ultimately that broke the pipelines in turn. Since we're in freeze we agreed to just revert the patches. Next attempt should happen after the freeze. I'll go ahead and post the revert.