No answer ???

What does it mean :

- you don’t have a window for the review ?

- you are not interested in getting these developments ?

- you don’t agree with the delivery process I proposed ?

- you prefer getting the whole set of the v2 versions before reviewing ?

Please, just let me know…

Thanks,

Yves.

De : Yves Vinter
Envoyé : mardi 25 novembre 2014 10:10
À : libvir-list@redhat.com
Objet : Waiting for review of [libvirt] [PATCH v2 2/21] hyperv: implementation of virConnectGetVersion

Hi All,

As I described the 27^th of October in the following thread:

https://www.redhat.com/archives/libvir-list/2014-October/msg00840.html

[libvirt] [PATCH v2 0/21] hyperv: hyperv: set of new functionalities

new functionalities has been implemented in the libvirt hyperv driver as a set of 21 patches.

PATCH 01/21: hyperv: avoid query memleaks on failure

PATCH 02/21: hyperv: implementation of virConnectGetVersion

PATCH 03/21: hyperv: implementation of virConnectGetCapabilities

PATCH 04/21: hyperv: implementation of virDomainGetVcpus and virConnectGetMaxVcpus

PATCH 05/21: hyperv: implementation of virNodeGetFreeMemory

PATCH 06/21: hyperv: implementation of virDomainShutdown and virDomainShutdownFlags

PATCH 07/21: hyperv: implementation of virDomainGetSchedulerType and virDomainGetSchedulerParameters

PATCH 08/21: hyperv: implementation of virNetworkLookupByName

PATCH 09/21: hyperv: implementation of virNetworkGetXMLDesc

PATCH 10/21: hyperv: implementation of virConnectNumOfNetworks and virConnectListNetworks

PATCH 11/21: hyperv: implementation of virConnectNumOfDefinedNetworks and virConnectListDefinedNetworks

PATCH 12/21: hyperv: implementation of hypervInvokeMethod to handle complex parameters

PATCH 13/21: hyperv: implementation of virDomainSetAutostart and virDomainGetAutostart

PATCH 14/21: hyperv: implementation of virDomainSetMaxMemory

PATCH 15/21: hyperv: implementation of virDomainSetMemory and virDomainSetMemoryFlags

PATCH 16/21: hyperv: implementation of virDomainSetVcpus and virDomainSetVcpusFlags

PATCH 17/21: hyperv: implementation of virDomainUndefine and virDomainUndefineFlags

PATCH 18/21: hyperv: implementation of internal function hypervDomainAttachDisk

PATCH 19/21: hyperv: implementation of internal function hypervDomainAttachNetwork

PATCH 20/21: hyperv: implementation of virDomainAttachDevice and virDomainAttachDeviceFlags

PATCH 21/21: hyperv: implementation of virDomainDefineXML and virDomainCreateXML

A first version of this set has been submitted the 8^th of October.

The first 3 patches have been already reviewed by Eric and the first patch has been pushed in the main stream.

Based on the remarks after this 3 reviews, I will produce a V2 for the whole set of patches.

It will be more convenient for me to submit V2 versions patch after patch, only after the previous one has been approved and pushed in the main branch.

The V2 of patch 02/21 has been submitted the 27^th of October here:

https://www.redhat.com/archives/libvir-list/2014-October/msg00824.html

[libvirt] [PATCH v2 2/21] hyperv: implementation of virConnectGetVersion

I’ve not received any feedback since, and it has not been pushed in the main stream.

Is there any issue?

I’m still waiting for its approval before submitting the next patch…

Thanks for you answer,

Yves.