Re: [libvirt] [PATCH 3/5] qemu: vnc: mark websocket as used on reconnect

On 17.07.2018 23:16, John Ferlan wrote:

On 07/04/2018 07:03 AM, Nikolay Shirokovskiy wrote:

...

Signed-off-by: Nikolay Shirokovskiy <nshirokovskiy@virtuozzo.com> --- src/qemu/qemu_process.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)

So your contention is that commit id 84067696 missed a condition?

I agree, but would like you to reference that commit id in your commit message before pushing - especially since AIUI websocket > 0 means it's a port we've specifically wanted reserved.

Honestly I don't undestand why I wrote this patch. On reconnection whether websocket is auto generated or not it will be marked as used in qemuProcessGraphicsReservePorts because it is > 0. Nikolay