Re: [libvirt] [PATCH 3/3] Expose event loop implementation as a public API

Not all applications have an existing event loop they need to integrate with. Forcing them to implement the libvirt event loop integration APIs is an undue burden. This just exposes our simple poll() based implementation for apps to use. So instead of calling virEventRegister(....callbacks...) The app would call virEventRegisterDefaultImpl() And then have a thread somewhere calling static bool quit = false; .... while (!quit) virEventRunDefaultImpl() * daemon/libvirtd.c, tools/console.c, tools/virsh.c: Convert to public event loop APIs * include/libvirt/libvirt.h.in, src/libvirt_private.syms: Add virEventRegisterDefaultImpl and virEventRunDefaultImpl * src/util/event.c: Implement virEventRegisterDefaultImpl and virEventRunDefaultImpl using poll() event loop * src/util/event_poll.c: Add full error reporting * src/util/virterror.c, include/libvirt/virterror.h: Add VIR_FROM_EVENTS --- daemon/libvirtd.c | 12 +---- include/libvirt/libvirt.h.in | 3 + include/libvirt/virterror.h | 1 + src/libvirt_private.syms | 8 ---- src/libvirt_public.syms | 6 +++ src/util/event.c | 94 +++++++++++++++++++++++++++++++++++++++++- src/util/event_poll.c | 24 ++++++++++- src/util/virterror.c | 3 + tools/console.c | 3 +- tools/virsh.c | 9 +--- 10 files changed, 133 insertions(+), 30 deletions(-)

+++ b/include/libvirt/virterror.h @@ -79,6 +79,7 @@ typedef enum { VIR_FROM_SYSINFO = 37, /* Error from sysinfo/SMBIOS */ VIR_FROM_STREAMS = 38, /* Error from I/O streams */ VIR_FROM_VMWARE = 39, /* Error from VMware driver */ + VIR_FROM_EVENT = 40, /* Error from event loop impl */ } virErrorDomain;

+++ b/src/libvirt_private.syms @@ -396,14 +396,6 @@ virEventUpdateTimeout; # event_poll.h virEventPollToNativeEvents; virEventPollFromNativeEvents; -virEventPollRunOnce; -virEventPollInit; -virEventPollRemoveTimeout; -virEventPollUpdateTimeout; -virEventPollAddTimeout; -virEventPollRemoveHandle; -virEventPollUpdateHandle; -virEventPollAddHandle;

+++ b/src/libvirt_public.syms @@ -424,4 +424,10 @@ LIBVIRT_0.8.8 { virConnectGetSysinfo; } LIBVIRT_0.8.6; +LIBVIRT_0.9.0 { + global: + virEventRegisterDefaultImpl; + virEventRunDefaultImpl; +} LIBVIRT_0.8.8;

+ +/** + * virEventRegisterDefaultImpl: + * + * Registers a default event implementation based on the + * poll() system call. This is a generic implementation + * that can be used by any client application which does + * not have a need to integrate with an external event + * loop impl.

+ +/** + * virEventRunDefaultImpl: + * + * Run one iteration of the event loop. Applications + * will generally want to have a thread which invokes + * this method in an infinite loop

+int virEventRunDefaultImpl(void) +{ + VIR_DEBUG0("");