Re: [libvirt] [PATCH v3 2/4] monitor: Enable adding an inherited fd to an fd set

On 10/17/2012 09:45 AM, Kevin Wolf wrote:

Am 16.10.2012 20:08, schrieb Corey Bryant:

...

qmp_add_fd() gets an fd that was received over a socket with SCM_RIGHTS and adds it to an fd set. This patch adds support that will enable adding an fd that was inherited on the command line to an fd set.

Note: All of the code added to monitor_fdset_add_fd(), with the exception of the error path for non-valid fdset-id, is code motion from qmp_add_fd().

Signed-off-by: Corey Bryant <coreyb@linux.vnet.ibm.com>

And the non-valid fdset-id error case leaks fd now, right?

Kevin

Yes, I need to fix that. Thanks. I'll send out a v4. -- Regards, Corey Bryant