On 04/18/2012 08:23 AM, Jiri Denemark wrote:
On Mon, Apr 16, 2012 at 23:05:57 -0600, Eric Blake wrote:
In order to track a block copy job across libvirtd restarts, we need to save internal XML that tracks the name of the file holding the mirror. Displaying this name in dumpxml might also be useful to the user, even if we don't yet have a way to (re-) start a domain with mirroring enabled up front. This is done with a new <mirror> sub-element to <disk>, as in:
v5: allow but ignore <mirror> on inactive, and add tests
docs/formatdomain.html.in | 13 ++++ docs/schemas/domaincommon.rng | 24 +++++++- src/conf/domain_conf.c | 62 +++++++++++++++++--- src/conf/domain_conf.h | 4 + .../qemuxml2argvdata/qemuxml2argv-disk-mirror.xml | 42 +++++++++++++ .../qemuxml2xmlout-disk-mirror.xml | 40 +++++++++++++ tests/qemuxml2xmltest.c | 42 ++++++++------ 7 files changed, 198 insertions(+), 29 deletions(-) create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-disk-mirror.xml create mode 100644 tests/qemuxml2xmloutdata/qemuxml2xmlout-disk-mirror.xml
OK, looks good as well with the comment from 4/23 applied. BTW, not removing unrelated () would make the patch a bit smaller for review ;-)
I'll work on splitting the () trimming into a separate patch, which can be applied now, similar to what I already did for virsh in patch 1/23. -- Eric Blake eblake@redhat.com +1-919-301-3266 Libvirt virtualization library http://libvirt.org