Re: [libvirt] [PATCH 04/10] conf: use virXMLPropString for IOMMU def parsing
On Wed, Aug 16, 2017 at 02:40:41PM +0200, Pavel Hrdina wrote:
XPath is good for random search of elements, not for accessing
attributes of one node.
Signed-off-by: Pavel Hrdina <phrdina(a)redhat.com>
---
Notes:
hint: review with -b
src/conf/domain_conf.c | 57 ++++++++++++++++++++++++++------------------------
1 file changed, 30 insertions(+), 27 deletions(-)
The STRDUP in virXPathString is still redundant, but not sure if it's
worth over-optimizning further.
ACK
Jan
Attachments:
- signature.asc (application/pgp-signature — 833 bytes)