On Wed, 2019-01-23 at 16:32 -0500, Cole Robinson wrote: [...]
+++ b/tests/qemuxml2argvdata/virtio-non-transitional.xml @@ -0,0 +1,18 @@ +<domain type='qemu'> + <name>QEMUGuest1</name> + <uuid>c7a5fdbd-edaf-9455-926a-d65c16db1809</uuid> + <memory unit='KiB'>219136</memory> + <os> + <type arch='x86_64' machine='q35'>hvm</type> + <boot dev='hd'/>
You can drop the <boot> element both here... [...]
+++ b/tests/qemuxml2argvdata/virtio-transitional.xml @@ -0,0 +1,18 @@ +<domain type='qemu'> + <name>QEMUGuest1</name> + <uuid>c7a5fdbd-edaf-9455-926a-d65c16db1809</uuid> + <memory unit='KiB'>219136</memory> + <os> + <type arch='x86_64' machine='q35'>hvm</type> + <boot dev='hd'/>
... and here. Assuming the results of the ongoing discussion about formatting model='virtio' when the model had not been provided are handled through either a follow-up patch or with a respin, Reviewed-by: Andrea Bolognani <abologna@redhat.com> -- Andrea Bolognani / Red Hat / Virtualization