Re: [libvirt] [PATCH] vbox: Add support for VirtualBox 4.0
2010/12/28 Daniel Veillard <veillard(a)redhat.com>:
On Tue, Dec 28, 2010 at 12:52:10AM +0100, Matthias Bolte wrote:
> Add vboxArrayGetWithUintArg to handle new signature variations. Also
> refactor vboxArrayGet* implementation to use a common helper function.
>
> Deal with the incompatible changes in the VirtualBox 4.0 API. This
> includes major changes in virtual machine and storage medium lookup,
> in RDP server property handling, in session/lock handling and other
> minor areas.
>
> VirtualBox 4.0 also dropped the old event API and replaced it with a
> completely new one. This is not fixed yet and will be addressed in
> another patch. Therefore, currently the domain events are supported
> for VirtualBox 3.x only.
>
> Based on initial work from Jean-Baptiste Rouault.
> ---
>
> This mail omits the 7451 lines of addition for the vbox_CAPI_v4_0.h
> file on purpose. vbox_CAPI_v4_0.h is taken from the VirtualBox 4.0 SDK
> and got the same treatment as the other vbox_CAPI_v*.h files. Like
> the note about not to regenerate it in the context of libvirt, it's
> preprocessor code is indented to pass the syntax-check, all methods
> are marked with __stdcall on Windows, etc.
Okay, the patch looks relatively safe even at that late stage,
since it's mostly automatic changes to use the new macro or new code
specifically enclosed in VBOX_API_VERSION conditional defines.
Since it's a feature I would rather like to see in 0.8.7 I'm fine
pushing this out now, but this will need to be tested based on
snapshots this week.
ACK,
Daniel
I tested the basic stuff like
defining/undefineing/starting/stopping/etc a domain on Linux and
Windows and I'll try to cover the other parts of the driver in the
next days before the release, but I don't except new problems as most
of the changes in the VirtualBox API 4.0 just renamed methods or moved
methods to different object types. The huge change in the event
handling will be addressed after the 0.8.7 release.
Thanks, pushed.
Matthias