Re: [libvirt] [PATCHv3 02/16] Domain conf: allow more than one IP address for net devices
On Tue, Nov 04, 2014 at 01:43:58PM +0100, Cedric Bosdonnat wrote:
Hi Daniel,
On Wed, 2014-10-22 at 11:03 +0100, Daniel P. Berrange wrote:
> I think it is probably worth a followup patch to make drivers
> report VIR_ERR_CONFIG_UNSUPPORTED in the case where nips > 1
> and the driver only supports nips==1.
Shouldn't we just VIR_WARN this? That would avoid breaking as we could
get the first ip address...
No, it is policy that if we don't support something we must always
return an error to the application. If we only warned, then there is
no way for an application to detect if the feature works or not.
Regards,
Daniel
--
|: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org -o- http://virt-manager.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|