Re: [libvirt] [PATCH 0/3] virsh: undefine: Clarify things around snapshots

On 6/5/19 6:23 AM, Peter Krempa wrote:

Peter Krempa (3): virsh: undefine: Clarify help string for --snapshots-metadata virsh: undefine: Rename --delete-snapshots to --delete-storage-volume-snapshots virsh: undefine: Clarify that --delete-storage-volume-snapshots causes failures

Interesting - I think I had copied '--delete-snapshots' into '--delete-checkpoints' in my incremental backup work because I had fallen prey to the wrong meaning that you are trying to clean up here. I guess that's another thing I get to revisit before posting v9. ACK series once the grammar in 3/3 is fixed. -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3226 Virtualization: qemu.org | libvirt.org