Re: [libvirt] [PATCH] qemu_agent: support guest-info command

On Tue, Jun 26, 2012 at 12:42:03PM +0900, MATSUDA, Daiki wrote: > Currently, libvirt qemu agent supports some QEMU Guest Agent's commands > or use them. But they are not adapted to communication test to the > Domain OS. > > So, QEMU Guest Agent provide 'guest-info' command to display its version > and their commands. And I wrote the codes for supporting it. > > virsh # guest-agent-info RHEL62_32 > Version: 1.1.0 > Commands: > guest-network-get-interfaces > guest-suspend-hybrid > guest-suspend-ram > guest-suspend-disk > guest-fsfreeze-thaw > guest-fsfreeze-freeze > guest-fsfreeze-status > guest-file-flush > guest-file-seek > guest-file-write > guest-file-read > guest-file-close > guest-file-open > guest-shutdown > guest-info > guest-ping > guest-sync > guest-sync-delimited I don't really think that this kind of API is relevant for the libvirt public API. Individual agent commands are wired up to specific libvirt public APIs as required. There is no compelling reason why an end user needs to know what agent commands are present. I would, however, support the introduction of an API int virDomainQemuAgentCommand(virDomainPtr domain, const char *cmd, char **result, unsigned int flags); and virsh command 'qemu-agent-command' as part of libvirt-qemu.h and libvirt-qemu.so. Basically an equivalent of the existing QEMU specific API virDomainQemuMonitorCommand(), but talking to the agent instead of the monitor Regards, Daniel