Re: [libvirt] [PATCH] conf: Allow all volume modes for disk type='lun' sources

On 05/11/2016 09:11 AM, Peter Krempa wrote: > Commit 82ba41108acd0f3f made possible to use direct mapped iSCSI > volumes in qemu as disk sources but didn't remove the define time check. > > Rework the check by simplifying the condition and allow any volumes to > be used with disk type='lun'. > --- > src/conf/domain_conf.c | 32 ++++++++++++-------------------- > 1 file changed, 12 insertions(+), 20 deletions(-) > ACK - (although you could change the comment "weren't translated" to "haven't been translated yet" if you felt so compelled.)