Re: [libvirt] [PATCH] Fix memory leak when lookup pool list with invalid type option
On 02/24/2014 08:04 AM, shyu wrote:
| And judging by the code, this is not upstream at all, right? I
guess
| this is not applicable upstream for half a year already, at least.
| Please submit patches that apply on top of current master when cloning
| from git://libvirt.org/libvirt.git .
|
Hi Martin, I think I made an mistake. Since I found this bug with 0.10.2-29.el6_5.4 so I
make
this patch according v0.10.2-maint branch. I knew it was already be fixed on upstream. I
thought
there should be fixed on v0.10.2-maint. Now I know that.
Thanks for your kind remind.
| Thanks for your effort, but I believe this is already fixed within
| commit d64af6ce as I already commented in the Bug you referenced.
If something is already fixed upstream and you merely want it backported
to the maintenance branch, then it's best to mention which commit id to
be cherry-picked onto which branch, rather than trying to write a new
patch from scratch. On this list, we assume that patches are against
the master branch unless stated otherwise in the subject line, and
patches to maint branches should generally be created with 'cherry-pick
-x' so that we know which patch from the master branch they are based on.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
Attachments:
- signature.asc (application/pgp-signature — 604 bytes)