Re: [libvirt] [PATCH 1/6] Add pci utility functions
On Thu, Feb 26, 2009 at 02:56:13PM +0000, Daniel P. Berrange wrote:
On Wed, Feb 25, 2009 at 08:17:08PM +0000, Mark McLoughlin wrote:
> Add implementations of dettach, reattach and reset for
> PCI devices.
[...]
> Signed-off-by: Mark McLoughlin <markmc(a)redhat.com>
In absence of any objections, I ACK this patch, because it is
internal only code we can easily change later as required.
> +#define PCI_PM_CTRL_NO_SOFT_RESET 0x4 /* No reset for D3hot->D0 */
I've been told off-list, that this last constant should be 0x8 instead
of 0x4
Okay, I have commited the 6 patches with that small fix to pci.c,
Daniel
--
Daniel Veillard | libxml Gnome XML XSLT toolkit http://xmlsoft.org/
daniel(a)veillard.com | Rpmfind RPM search engine http://rpmfind.net/
http://veillard.com/ | virtualization library http://libvirt.org/