Re: [libvirt] [PATCH 2/3]cgroup: show error when EINVAL caught

From: Chen Hanxiao <chenhanxiao(a)cn.fujitsu.com&gt; When EINVAL caught, tell user that what values are invalid for what field. Signed-off-by: Chen Hanxiao <chenhanxiao(a)cn.fujitsu.com&gt; --- src/util/vircgroup.c | 12 +++++++++++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/src/util/vircgroup.c b/src/util/vircgroup.c index e99caf5..a98bd63 100644 --- a/src/util/vircgroup.c +++ b/src/util/vircgroup.c @@ -664,12 +664,21 @@ virCgroupSetValueStr(virCgroupPtr group, { int ret = -1; char *keypath = NULL; + char *tmp = NULL; if (virCgroupPathOfController(group, controller, key, &keypath) < 0) return -1; VIR_DEBUG("Set value '%s' to '%s'", keypath, value); if (virFileWriteStr(keypath, value, 0) < 0) { + if (errno == EINVAL) { + tmp = strrchr(keypath, '/'); + if (!tmp) + goto cleanup;

+ virReportSystemError(errno, + _("Invalid value '%s' for '%s'"), value, ++tmp); + goto cleanup; + } virReportSystemError(errno, _("Unable to write to '%s'"), keypath); goto cleanup;