Re: [PATCH 14/24] qemuValidateDomainVCpuTopology: Remove misconfiguration warning
On Mon, Aug 21, 2023 at 02:57:09PM +0200, Ján Tomko wrote:
On a Thursday in 2023, Peter Krempa wrote:
> VIR_WARN of a misconfiguration of a VM is not really going to be seen in
> most cases as it's simply logged, and if the VM works users are not
> likely to dig through logs.
Should we put it under VIR_DOMAIN_START_WERROR? :)
If a config scenario is explicitly deprecated and expected to be
remove, then we should be using the 'taint' mechanism to alert
users/apps. This is queryable by apps and also ends up in the per
VM log files as a warning.
With regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|