On Fri, 2021-03-05 at 13:43 +0100, Ján Tomko wrote:
On a Friday in 2021, Andrea Bolognani wrote:
On Thu, 2021-03-04 at 17:47 +0100, Ján Tomko wrote:
On a Wednesday in 2021, Roman Bogorodskiy wrote:
+keycode_dep = declare_dependency(sources: keycode_gen_sources)
Please format this as:
keycode_dep = declare_dependency( sources: keycode_gen_sources )
to match the prevailing style.
Small correction: it should be
keycode_dep = declare_dependency( sources: keycode_gen_sources, )
Note the additional comma, which allows us to have cleaner diffs when making further changes, and the indentation being only two spaces instead of three.
The three spaces come from your MUA misquoting me. I see two spaces in my version of the e-mail, as well as the list archive: https://listman.redhat.com/archives/libvir-list/2021-March/msg00252.html
(Not that my MUA is any better in that regard - the indentation in my quoting of Roman's patch is wrong too)
That's interesting: if I look at the HTML version you linked above or copy and paste the snippet from it, the indentation is indeed two spaces; however, if I look at the copy in my local mailbox or at the full mbox taken from https://listman.redhat.com/archives/libvir-list/2021-March.txt.gz there are three spaces. Looking at the headers for your message, I see Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="kmvAAwZj779MjF+K" followed by Content-Type: text/plain; charset=iso-8859-1; format=flowed Content-Disposition: inline Content-Transfer-Encoding: quoted-printable and the body contains stuff like keycode_dep =3D declare_dependency( Reviewed-by: J=E1n Tomko so I think perhaps your MUA's configuration might be to blame for the weirdness we're seeing? Honestly, I just don't understand email well enough to be able to tell :) -- Andrea Bolognani / Red Hat / Virtualization