Re: [libvirt] [PATCH 1/4] qemu: hostdev: Unify naming for qemuPrepareHost*Devices()

On 10/20/2015 11:20 AM, Andrea Bolognani wrote: > No functional changes. > --- > src/qemu/qemu_hostdev.c | 40 ++++++++++++++++++++-------------------- > src/qemu/qemu_hostdev.h | 22 +++++++++++----------- > src/qemu/qemu_hotplug.c | 9 ++++----- > 3 files changed, 35 insertions(+), 36 deletions(-) > > diff --git a/src/qemu/qemu_hostdev.c b/src/qemu/qemu_hostdev.c > index 706db0c..a4409d6 100644 > --- a/src/qemu/qemu_hostdev.c > +++ b/src/qemu/qemu_hostdev.c > @@ -156,9 +156,9 @@ qemuHostdevHostSupportsPassthroughLegacy(void) > > > static bool > -qemuPrepareHostdevPCICheckSupport(virDomainHostdevDefPtr *hostdevs, > - size_t nhostdevs, > - virQEMUCapsPtr qemuCaps) > +qemuPrepareHostPCIDevicesCheckSupport(virDomainHostdevDefPtr *hostdevs, > + size_t nhostdevs, > + virQEMUCapsPtr qemuCaps) > { > bool supportsPassthroughKVM = qemuHostdevHostSupportsPassthroughLegacy(); > bool supportsPassthroughVFIO = qemuHostdevHostSupportsPassthroughVFIO(); > @@ -219,18 +219,18 @@ qemuPrepareHostdevPCICheckSupport(virDomainHostdevDefPtr *hostdevs, > } > > int > -qemuPrepareHostdevPCIDevices(virQEMUDriverPtr driver, > - const char *name, > - const unsigned char *uuid, > - virDomainHostdevDefPtr *hostdevs, > - int nhostdevs, > - virQEMUCapsPtr qemuCaps, > - unsigned int flags) > +qemuPrepareHostPCIDevices(virQEMUDriverPtr driver, > + const char *name, > + const unsigned char *uuid, > + virDomainHostdevDefPtr *hostdevs, > + int nhostdevs, > + virQEMUCapsPtr qemuCaps, > + unsigned int flags) > { > int ret = -1; > virHostdevManagerPtr hostdev_mgr = driver->hostdevMgr; > > - if (!qemuPrepareHostdevPCICheckSupport(hostdevs, nhostdevs, qemuCaps)) > + if (!qemuPrepareHostPCIDevicesCheckSupport(hostdevs, nhostdevs, qemuCaps)) > goto out; > > ret = virHostdevPreparePCIDevices(hostdev_mgr, QEMU_DRIVER_NAME, Typically when searching I can change the "virDomainFoo" type string to a "qemuDomainFoo" string and find the qemu API. Here those you'll see there's a virHostDevPreparePCIDevices(), so in a way I'd expect a qemuHostdevPreparePCIDevices Since is a "qemu_hostdev.{c,h}" type change, then theoretically all the API's in here should be qemuHostdevFoo, right? Rather than qemuPrepareFoo, qemuUpdateFoo, and qemuDomainReAttachFoo It'd be qemuHostdevPrepare, qemuHostdevUpdate, and qemuHostdevReAttach and your new API would be qemuHostdevUpdateActiveDevices