On 3/22/19 7:30 AM, Peter Krempa wrote:
There were two outliers at the end of the file beyond the Vcpu functions.
Signed-off-by: Laine Stump <laine@laine.org> --- src/qemu/qemu_hotplug.c | 174 ++++++++++++++++++++-------------------- 1 file changed, 87 insertions(+), 87 deletions(-) While this obscures git history I don't feel strongly against doing
On Thu, Mar 21, 2019 at 18:28:51 -0400, Laine Stump wrote: that.
That (and the trouble it causes for backports) is my main argument against "cosmetic" refactoring, and I definitely had misgivings while doing it, but cleanliness won out over accountability in the end (it would be nice if git could easily report the full history of a line, including when it was moved. You can get to the *real* origin by right clicking on deleted equivalent lines in gitk, but sometimes you have to go back half a dozen generations to find it (and then it doesn't provide a simple way to get back to the present). If only I remembered any of the teeny tiny bit of tcl/tk I learned 20 years ago, I might try to add that functionality to gitk :-P