Re: [libvirt] [PATCH 10/12] conf: Add support for choosing emulation of a TPM 2
On Thu, May 24, 2018 at 07:22:30AM -0400, Stefan Berger wrote:
On 05/24/2018 03:08 AM, Ján Tomko wrote:
> On Wed, May 23, 2018 at 02:33:08PM -0400, Stefan Berger wrote:
>> swtpm doesn't have all the bells and whistles of QEMU that we would have
>> a JSON interface to query the features from.
>
> With QEMU, we actually need to know some capabilities upfront, because
> different versions have had different ways of requesting the same
> functionality. Giving nicer errors for unsupported features is just a
> bonus.
>
> With qemu-img, we only care about one way of representing the
> functionality and let it print an error if something's compiled out.
Ok, then let me remove it. v7 will have that change. Not sure what to
do about the existing Reviewed-by's. Intend to keep them.
The usual thing to do is keep them unless you make a significant change
to the commit. Its presence in the commit message should tell the
reviewer that he does not need to look at it again.
Jano
Attachments:
- signature.asc (application/pgp-signature — 833 bytes)