On 23.06.2014 16:05, Daniel P. Berrange wrote:
On Fri, Jun 20, 2014 at 04:19:06PM +0200, Michal Privoznik wrote:
The functions in question are qemuHostdevHostSupportsPassthroughLegacy and qemuHostdevHostSupportsPassthroughVFIO. At the same time the functions are renamed to match 'vir' prefix instead of 'qemu' one.
I'm not sure I see the reason for moving these functions ? They're QEMU specific surely ?
eg
@@ -1635,3 +1640,71 @@ virHostdevUpdateDomainActiveDevices(virHostdevManagerPtr mgr,
return 0; } + +#if HAVE_LINUX_KVM_H +bool +virHostdevHostSupportsPassthroughLegacy(void) +{ + int kvmfd = -1; + bool ret = false; + + if ((kvmfd = open("/dev/kvm", O_RDONLY)) < 0) + goto cleanup;
is going to be useless for anything except QEMU driver.
Regards, Daniel
Well, I thought other drivers might use it in the future, but the patch set can live without this patch. I'm fine with dropping it. Michal