Re: [PATCH V2 0/4] Rework qemu internal active snapshots to use QMP

On Wed, Jul 17, 2024 at 21:21:33 +0300, Nikolai Barybin via Devel wrote: > Den, Peter, Daniel thank you for your comments! > > I'm sending v2 of this patchset. > > Changes since last revision: > > - dropped [PATCH 4/4] qemu monitor: reap qemu_monitor_text > > - added new patch: qemu capabilities: add QEMU_CAPS_SNAPSHOT_SAVE/_DELETE > > - preserved old-style snapshotting (HMP savevm) in case we have QEMU < 6.0 > > - enhanced requirements for allowing snapshotting. All writable disks > should be qcow2, non-shared. If such disks exist and we have qcow2 > NVRAM, add NVRAM device to the list of wrdevs. But never save vmstate > to NVRAM > > - make char** wrdevs list allocation inside > qemuSnapshotActiveInternalGetWrdevListHelper() Note that I'll clean up the patches, so there's no need for you to send another version. My review will follow regardless as documentation of what I'll be changing.