Re: [libvirt] [PATCH 2/9] qemuDomain{Attach, Remove}NetDevice: Prefer qemuDomainSupportsNetdev
On 29.08.2016 06:52, Laine Stump wrote:
On 08/16/2016 11:41 AM, Michal Privoznik wrote:
> Depending on domain OS type, and interface address type we might
> not want to use -netdev even though qemu has the capability. We
> should use more advanced check implemented in
> qemuDomainSupportsNetdev() function.
So the effect of using qemuDomainSupportsNetdev rather than a direct
check of the capability is that aarch64 network devices that are using
neither PCI nor virtio-mmio connections would get a different
commandline. Is there a particular situation where this makes a
difference, or did it just "look like the right thing to do"?
The latter one. When working on later patches from this patchset I've
spotted this inconsistency. I'm okay with dropping this one if it causes
confusion though.
Michal