On Mon, Aug 13, 2007 at 02:17:03PM -0400, Jim Paris wrote:
Here's take 3 of the QEMU/KVM save/restore support. Thanks for
your
input.
Changes since last time:
- Remove escape sequence filtering, it's not necessary.
- Clean up stdin handling in virExec, use -1 to signify unused
- Add signal-safe read/write wrappers that handle EINTR and use them.
- Add version and padding to image header, and check version on restore.
- Include null-termination in XML data & length
- Show name of conflicting domain in error message
Everything seems to work well in my tests. I've run into a few rare
cases where the migration doesn't work correctly (causing segfaults in
the guest, or kvm to crash), but it's not libvirt's fault, and libvirt
handles the failures well.
It all worked nicely for me too - exposed a bug in virt-manager too :-)
Thanks again for coding & debugging this all
Regards,
Dan.
--
|=- Red Hat, Engineering, Emerging Technologies, Boston. +1 978 392 2496 -=|
|=- Perl modules:
http://search.cpan.org/~danberr/ -=|
|=- Projects:
http://freshmeat.net/~danielpb/ -=|
|=- GnuPG: 7D3B9505 F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 -=|