Re: [libvirt] [PATCHv2 01/10] nodeinfo: Rename linuxNodeInfoCPUPopulate and export it properly

On Fri, Oct 18, 2013 at 05:05:41PM +0200, Peter Krempa wrote: > Call it virNodeInfoLinuxPopulateCPU and use the header file to export > it instead of extern definition in the test file. > --- > src/libvirt_linux.syms | 2 +- > src/nodeinfo.c | 14 +++++--------- > src/nodeinfo.h | 5 +++++ > tests/nodeinfotest.c | 6 +----- > 4 files changed, 12 insertions(+), 15 deletions(-) >

I think it would be desirable to crate a nodeinfopriv.h header for this, since it isn't intended to be part of the internal API.