On Wed, Jun 16, 2021 at 15:58:30 +0200, Ján Tomko wrote:
When adding support for externally launched virtiofsd, I was too liberal and did not require a target.
But the target is required, because it's passed to the QEMU device, not to virtiofsd.
https://bugzilla.redhat.com/show_bug.cgi?id=1969232
Fixes: 12967c3e1333a6e106110f449ccb1e96279b9527 Signed-off-by: Ján Tomko <jtomko@redhat.com> --- docs/formatdomain.rst | 1 + docs/kbase/virtiofs.rst | 1 + src/conf/domain_conf.c | 2 +- tests/qemuxml2argvdata/vhost-user-fs-sock.xml | 1 + 4 files changed, 4 insertions(+), 1 deletion(-)
[...]
diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 139cdfc0a7..ef784575d2 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -9896,7 +9896,7 @@ virDomainFSDefParseXML(virDomainXMLOption *xmlopt, goto error; }
- if (target == NULL && !sock) { + if (target == NULL) { virReportError(VIR_ERR_NO_TARGET, source ? "%s" : NULL, source); goto error;
This will have to end up in a validation functions or existing configs with missing target will vanish which is unacceptable.