Re: [PATCH] tests: qemucapabilities: Update qemu caps dump for the qemu-7.0.0 release on x86_64
On Mon, Apr 25, 2022 at 16:40:17 +0200, Michal Prívozník wrote:
On 4/25/22 16:36, Peter Krempa wrote:
> On Wed, Apr 20, 2022 at 13:02:12 +0200, Peter Krempa wrote:
>> Few minor changes in qemu since the last update:
>> - PIIX4_PM gained 'x-not-migrate-acpi-index' property
>
> Based on the discussion I can drop this line.
>
>> - 'cocoa' display and corresponding props (not present in this
build)
>>
>> Changes in build:
>> - dbus display driver re-enabled
>> - gtk display support re-disabled
>> - xen support re-disabled
>>
>> Signed-off-by: Peter Krempa <pkrempa(a)redhat.com>
>> ---
>> .../caps_7.0.0.x86_64.replies | 583 ++++++++----------
>> .../caps_7.0.0.x86_64.xml | 10 +-
>> 2 files changed, 257 insertions(+), 336 deletions(-)
>
> The rest is still open for review ;)
>
Is it? I though you push this kind of patches. I mean, what's there to
review? It's basically a generated file.
Hmm, I didn't really want to get a rule instantiated for this kind of
stuff, but yeah, in most cases there's nothing to do.
I actually do review them:
1) For new additions on x86 I'm looking for new stuff which might be
interesting for us, thus the "changelog" above, but I do that also when
I'm sending patches
2) It's important to look that the capabilities don't regress and also
potential stuff which might have test fallout.
In case when I'm sending those I make sure that doesn't happen so I'll
be okay just to push these without review, but generally I'd like to be
reviewing other submissions.