Re: [PATCH 1/3] qemu_namespace: Rename variable

On Wed, Oct 16, 2024 at 09:23:05 +0200, Martin Kletzander wrote: > The boolean actually tells whether the file existed when the function > was called and using it in more places later on makes them > confusing (e.g. do something with a file if it does not exist). To > better reflect the above and prepare for next patch rename this > variable. > > Signed-off-by: Martin Kletzander <mkletzan(a)redhat.com&gt; > --- > src/qemu/qemu_namespace.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/src/qemu/qemu_namespace.c b/src/qemu/qemu_namespace.c > index bbe3d5a1f78a..71e29b4ba4f6 100644 > --- a/src/qemu/qemu_namespace.c > +++ b/src/qemu/qemu_namespace.c > @@ -1002,10 +1002,10 @@ qemuNamespaceMknodOne(qemuNamespaceMknodItem *data) > bool isDev = S_ISCHR(data->sb.st_mode) || S_ISBLK(data->sb.st_mode); > bool isReg = S_ISREG(data->sb.st_mode) || S_ISFIFO(data->sb.st_mode) || S_ISSOCK(data->sb.st_mode); > bool isDir = S_ISDIR(data->sb.st_mode); > - bool exists = false; > + bool existed = false; You can also add a comment explaining this further as the function itself isn't documented to have these semantics.

Anyways ... Reviewed-by: Peter Krempa <pkrempa(a)redhat.com&gt;