Re: [libvirt] [PATCH 09/35] qemu: block: Add support for accessing directories via the 'vvfat' driver
On Tue, May 01, 2018 at 20:21:11 -0400, John Ferlan wrote:
On 04/25/2018 11:15 AM, Peter Krempa wrote:
> Handle VIR_STORAGE_TYPE_DIR in qemuBlockStorageSourceGetBackendProps so
> that a 'vvfat' driver is used, which emulates a FAT filesystem
> containing the folders.
>
> qemu requires us to add it as a storage layer, since a 'raw' layer is
> usually put on top of it.
>
> Signed-off-by: Peter Krempa <pkrempa(a)redhat.com>
> ---
> src/qemu/qemu_block.c | 27 ++++++++++++++++++++++++++-
> 1 file changed, 26 insertions(+), 1 deletion(-)
>
So I suppose the only question I have for this one relates to whether
vvfat is supported in QEMU 1.5 or later and that's been the expectation
to use it for a long time, but libvirt wasn't doing the right thing?
Actually this code is not used yet mostly and will be only once we
switch to blockdev. Since blockdev support will require a much newer
qemu anyways we are fine to change this now.
Assuming 1.5 or later and that we don't have to do anything special or
use qemuBlockStorageSourceGetFileProps for some variant between 1.5 and
when vvfat was first supported,
Currently we format it the old way by using -drive, which will continue
to be supported.
Reviewed-by: John Ferlan <jferlan(a)redhat.com>
John
I'm half surprised we didn't have some test failure!
Well, since it was not used there wasn't much test coverage. The test
coverage was mostly in the XML->json->XML test, which did not handle the
vvfat case.
This series adds better coverage at least for the formatter. This will
also lessen the need to add a lot of xml->argv tests, since the
convertor will be tested separately.
--
libvir-list mailing list
libvir-list(a)redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Attachments:
- signature.asc (application/pgp-signature — 833 bytes)