On 01/26/2011 05:29 AM, Daniel P. Berrange wrote:
On Tue, Jan 25, 2011 at 03:04:57PM -0700, Eric Blake wrote:
On 01/14/2011 06:46 AM, Daniel P. Berrange wrote:
The 'id' setting for the chardev should really have a prefix on it, because we won't want it to be the same as the 'id' setting used for the -device option.
Done with the attached patch. git send-email won't let me send it directly, since it has a line longer than SMTP limits for inline mail:
fatal: /tmp/canS3cO9Y0/0001-qemu-use-separate-alias-for-chardev-and-associated-d.patch: 163: patch contains a line longer than 998 characters warning: no patches were sent
-- Eric Blake eblake@redhat.com +1-801-349-2682 Libvirt virtualization library http://libvirt.org
From d4a3f317dbd6b5b513b505d0eee21f9ec1a2d362 Mon Sep 17 00:00:00 2001 From: Eric Blake <eblake@redhat.com> Date: Tue, 25 Jan 2011 14:59:50 -0700 Subject: [PATCH] qemu: use separate alias for chardev and associated device
* src/qemu/qemu_command.c (qemuBuildChrChardevStr): Alter the chardev alias. (qemuBuildCommandLine): Output an id for the chardev counterpart. * tests/qemuxml2argvdata/*: Update tests to match. Reported by Daniel P. Berrange.
ACK
Thanks. This was independent enough of smartcard that I went ahead and pushed it. (For smartcard, I'm still working on addressing the review comments from v3; mainly the minor tweaks to the xml documentation to match reality, and fallout in the code). -- Eric Blake eblake@redhat.com +1-801-349-2682 Libvirt virtualization library http://libvirt.org