Re: [libvirt] [PATCH V2 0/4] Extend <hap> to a tristate

On 02/29/2016 09:00 PM, Jim Fehlig wrote: > An expanded V2 of > > https://www.redhat.com/archives/libvir-list/2016-February/msg00140.html > > In V2, the <hap> feature is extended with a state='on|off' attribute to > allow differentiating the 'on' and 'off' states with not set (or hypervisor > default). Any comments about this approach? I essentially followed the same pattern as the <pvspinlock> and <vmport> hypervisor features. Thanks! Regards, Jim > Obviously post 1.3.2 material. See individual patches for details. > > Jim Fehlig (4): > conf: add 'state' attribute to <hap> feature > xenconfig: change 'hap' setting to align with Xen behavior > Xen drivers: show hap enabled by default in capabilities > libxl: support enabling and disabling <hap> feature > > docs/formatdomain.html.in | 6 ++- > docs/schemas/domaincommon.rng | 6 ++- > src/conf/domain_conf.c | 4 +- > src/libxl/libxl_conf.c | 20 ++++++-- > src/xen/xen_hypervisor.c | 2 +- > src/xenconfig/xen_common.c | 14 ++--- > .../test-disk-positional-parms-full.cfg | 1 - > .../test-disk-positional-parms-partial.cfg | 1 - > ...est-fullvirt-direct-kernel-boot-bogus-extra.cfg | 1 - > .../test-fullvirt-direct-kernel-boot-extra.cfg | 1 - > .../test-fullvirt-direct-kernel-boot.cfg | 1 - > tests/xlconfigdata/test-fullvirt-multiusb.cfg | 1 - > tests/xlconfigdata/test-fullvirt-nohap.cfg | 26 ++++++++++ > tests/xlconfigdata/test-fullvirt-nohap.xml | 59 ++++++++++++++++++++++ > tests/xlconfigdata/test-new-disk.cfg | 1 - > tests/xlconfigdata/test-rbd-multihost-noauth.cfg | 1 - > tests/xlconfigdata/test-spice-features.cfg | 1 - > tests/xlconfigdata/test-spice.cfg | 1 - > tests/xlconfigdata/test-vif-rate.cfg | 1 - > tests/xlconfigtest.c | 1 + > tests/xmconfigdata/test-escape-paths.cfg | 1 - > .../xmconfigdata/test-fullvirt-default-feature.cfg | 1 - > tests/xmconfigdata/test-fullvirt-force-hpet.cfg | 1 - > tests/xmconfigdata/test-fullvirt-force-nohpet.cfg | 1 - > tests/xmconfigdata/test-fullvirt-localtime.cfg | 1 - > tests/xmconfigdata/test-fullvirt-net-netfront.cfg | 1 - > tests/xmconfigdata/test-fullvirt-new-cdrom.cfg | 1 - > tests/xmconfigdata/test-fullvirt-nohap.cfg | 28 ++++++++++ > tests/xmconfigdata/test-fullvirt-nohap.xml | 51 +++++++++++++++++++ > tests/xmconfigdata/test-fullvirt-parallel-tcp.cfg | 1 - > .../test-fullvirt-serial-dev-2-ports.cfg | 1 - > .../test-fullvirt-serial-dev-2nd-port.cfg | 1 - > tests/xmconfigdata/test-fullvirt-serial-file.cfg | 1 - > tests/xmconfigdata/test-fullvirt-serial-null.cfg | 1 - > tests/xmconfigdata/test-fullvirt-serial-pipe.cfg | 1 - > tests/xmconfigdata/test-fullvirt-serial-pty.cfg | 1 - > tests/xmconfigdata/test-fullvirt-serial-stdio.cfg | 1 - > .../test-fullvirt-serial-tcp-telnet.cfg | 1 - > tests/xmconfigdata/test-fullvirt-serial-tcp.cfg | 1 - > tests/xmconfigdata/test-fullvirt-serial-udp.cfg | 1 - > tests/xmconfigdata/test-fullvirt-serial-unix.cfg | 1 - > tests/xmconfigdata/test-fullvirt-sound.cfg | 1 - > tests/xmconfigdata/test-fullvirt-usbmouse.cfg | 1 - > tests/xmconfigdata/test-fullvirt-usbtablet.cfg | 1 - > tests/xmconfigdata/test-fullvirt-utc.cfg | 1 - > tests/xmconfigdata/test-no-source-cdrom.cfg | 1 - > tests/xmconfigdata/test-pci-devs.cfg | 1 - > tests/xmconfigtest.c | 1 + > 48 files changed, 202 insertions(+), 52 deletions(-) > create mode 100644 tests/xlconfigdata/test-fullvirt-nohap.cfg > create mode 100644 tests/xlconfigdata/test-fullvirt-nohap.xml > create mode 100755 tests/xmconfigdata/test-fullvirt-nohap.cfg > create mode 100644 tests/xmconfigdata/test-fullvirt-nohap.xml > -- libvir-list mailing list libvir-list(a)redhat.com https://www.redhat.com/mailman/listinfo/libvir-list