Re: [libvirt] [PATCH] spec: Only call ldconfig on RHEL7

On Tue, 2019-03-19 at 10:49 -0400, Cole Robinson wrote: > On 3/19/19 4:13 AM, Andrea Bolognani wrote: >> On Mon, 2019-03-18 at 15:35 -0400, Cole Robinson wrote: >>> %post client >>> >>> +%if 0%{?rhel} == 7 >>> /sbin/ldconfig >>> +%endif >>> %systemd_post libvirt-guests.service >>> >>> %postun client >>> >>> +%if 0%{?rhel} == 7 >>> /sbin/ldconfig >>> +%endif >>> %systemd_postun libvirt-guests.service >> >> IIUC ldconfig should be called after installing the libraries, but >> here we're calling it in %post(un) for the client subpackage which >> I believe is incorrect. We should fix that too. > > Calling /sbin/ldconfig from postun is recommended on fedora < 28 (and > thus I presume rhel7), according to: > > https://docs.fedoraproject.org/en-US/packaging-guidelines/Scriptlets/ > > The wiki page in the git commit also indicates that previously packages > would call /sbin/ldconfig on postun too, with the %postun -p > /sbin/ldconfig call What I was pointing out is that you're supposed to run ldconfig after (un)installing libraries: our libraries are shipped in the libvirt-libs package, but according to the spec file we're running ldconfig after (un)installing the client binaries instead, and that seems like a bug to me.