Re: [libvirt] [PATCH v2] pci: Use virPCIDeviceAddress in virPCIDevice
On Tue, 2015-12-15 at 10:05 +0100, Andrea Bolognani wrote:
@@ -1661,25 +1661,14 @@ virPCIDeviceFree(virPCIDevicePtr dev)
* @dev: device to get address from
*
* Take a PCI device on input and return its PCI address. The
- * caller must free the returned value when no longer needed.
+ * returned object is owned by the device and must not be freed.
*
* Returns NULL on failure, the device address on success.
*/
Not sending a v3 just for this, but if ACKed I'll also squash in
- * Returns NULL on failure, the device address on success.
+ * Returns: a pointer to the address, which can never be NULL.
to keep the documentation consistent with the actual behaviour.
Cheers.
--
Andrea Bolognani
Software Engineer - Virtualization Team