On Wed, May 20, 2015 at 01:35:43PM -0400, John Ferlan wrote:
On 05/20/2015 10:22 AM, Ján Tomko wrote:
s/read/refresh/ in the commit message?
On Wed, May 20, 2015 at 08:52:57AM -0400, John Ferlan wrote:
https://bugzilla.redhat.com/show_bug.cgi?id=1195882
Original commit id 'cbde3589' indicates that the cache file would be discarded if either the QEMU binary or libvirtd 'ctime' changes; however, the code only discarded if the QEMU binary time didn't match or if the new libvirtd ctime was later than what created the cache file.
This could lead to issues with respect to how the order of libvirtd images is created for maintenance or patch branches where if someone had a libvirtd created on 'date x' that was created from (a) backported patch(es) followed by a subsequent install of the primary release which would have 'date y' where if 'date x' was greater than 'date y', then features in a primary release branch may not be available.
I can see how here can be two daemons with different ctimes on the same system during development, so ACK to the change.
But they'd use different cache paths, right?
For privileged daemons, this depends on the LOCALSTATEDIR constant, which can be chosen at configure time. For non-privileged, it depends on the XDG_CACHE_HOME environment variable. I use ./autogen.sh --system for both my libvirt repos, so both store the cache under /var/ Jan