Re: [PATCH v2 2/2] tests: qemucapabilities: Add test data for the qemu-9.2 dev cycle on s390x

On 1/16/25 12:25, Michal Privoznik wrote: > Introduce capabilities based on qemu commit 'v9.2.0-945-ge8aa7fdcdd'. > > Notable changes: >      - new s390-ccw-virtio-10.0 machine type >      - old machine types (2.4 - 2.8) dropped >      - new CPU models >      - New devices: >        - virtio-mem-ccw >        - chardev now supports qemu-vdagent > > Signed-off-by: Michal Privoznik<mprivozn(a)redhat.com> > --- >   tests/domaincapsdata/qemu_9.3.0.s390x.xml     |   436 + >   .../caps_9.3.0_s390x.replies                  | 38101 ++++++++++++++++ >   .../qemucapabilitiesdata/caps_9.3.0_s390x.xml |  4268 ++ >   ...-deprecated-features-off.s390x-latest.args |     2 +- >   ...default-video-type-s390x.s390x-latest.args |     2 +- >   ...vfio-zpci-ccw-memballoon.s390x-latest.args |     2 +- >   .../launch-security-s390-pv.s390x-latest.args |     2 +- >   ...t-cpu-kvm-ccw-virtio-4.2.s390x-latest.args |     2 +- >   .../s390-defaultconsole.s390x-latest.args     |     2 +- >   .../s390-panic.s390x-latest.args              |     2 +- >   10 files changed, 42812 insertions(+), 7 deletions(-) >   create mode 100644 tests/domaincapsdata/qemu_9.3.0.s390x.xml >   create mode 100644 tests/qemucapabilitiesdata/caps_9.3.0_s390x.replies >   create mode 100644 tests/qemucapabilitiesdata/caps_9.3.0_s390x.xml I am wondering about the machine name being s390-ccw-virtio-10.0 and the cap/qemu files be called 9.3.0. Should that be called 10.0.0?

Also I think that you did the qemu recording in a host running in a zVM. This causes the feature cmmnt being reported as "not support" and causes the changes in the eight *.args files. I recommend to perform the probing with a host running in an LPAR to prevent the args files unnecessarily being changed. I can lend you a hand with it if required.