Re: [Libvir] PATCH: Report errors against virConnectPtr object

On Wed, Jul 11, 2007 at 08:55:35PM +0100, Daniel P. Berrange wrote: > The QEMU driver is not passing in a virConnectPtr object for many of the > places it calls virRaiseError. This means the errors aren't getting fed > back to the client correctly - particularly when starting a VM / network. > > This patch passes around a virConnectPtr object so errors get reported > correctly > > Instead of: > > $ ~/usr/bin/virsh --connect qemu://celery.virt.boston.redhat.com/system start demo > error: Failed to start domain demo > > It now gives > > $ ~/usr/bin/virsh --connect qemu://celery.virt.boston.redhat.com/system start demo > libvir: QEMU error : QEMU quit during console startup > qemu: could not open hard disk image '/root/demo.img' > error: Failed to start domain demo Hum, sounds great, the patch is a bit invasive but I don't see how to really avoid this with the current data structures. +1,