On 11/12/2014 08:47 AM, Peter Krempa wrote:
After recent refactors, starting a VM whose disk is backed by RBD storage would fail as the parser for the backing file specification string was not implemented in the metadata crawler.
Reuse qemu's parser to do this and fix a few things around.
In general ACK series - although I did make comments to specific patches - some for simple typos/nits and a couple for minor adjustments which should be addressable without the need for a v2 (patch 5, 8, 9, 11, & 12). Nice to know about virstoragetest.c - I can see the need to add perhaps some iscsi options there (learned something new today) John
Peter Krempa (12): docs: domain: Move docs for storage hosts under the <source> element test: virstoragetest: Add testing of network disk details util: buffer: Clarify scope of the escape operation in virBufferEscape util: storage: Add notice for extension of struct virStorageSource util: storage: Copy hosts of a storage file only if they exist qemu: Refactor qemuBuildNetworkDriveURI to take a virStorageSourcePtr tests: Reflow the expected output from RBD disk test util: split out qemuParseRBDString into a common helper util: storagefile: Split out parsing of NBD string into a separate func storage: Allow parsing of RBD backing strings when building backing chain storage: rbd: qemu: Add support for specifying internal RBD snapshots storage: rbd: Implement support for passing config file option
docs/formatdomain.html.in | 128 +++++---- docs/schemas/domaincommon.rng | 16 ++ src/conf/domain_conf.c | 52 +++- src/conf/domain_conf.h | 1 + src/conf/snapshot_conf.c | 6 +- src/libvirt_private.syms | 1 + src/qemu/qemu_command.c | 268 +++++------------- src/util/virbuffer.c | 5 +- src/util/virstoragefile.c | 313 +++++++++++++++++---- src/util/virstoragefile.h | 14 +- .../qemuxml2argv-disk-drive-network-rbd.args | 16 +- .../qemuxml2argv-disk-drive-network-rbd.xml | 25 ++ tests/virstoragetest.c | 65 ++++- 13 files changed, 587 insertions(+), 323 deletions(-)